Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure dirname(config_file_path) is not empty #45

Merged
merged 2 commits into from Nov 19, 2022

Conversation

hofaflo
Copy link
Contributor

@hofaflo hofaflo commented Nov 19, 2022

Using os.chdir to switch to the directory containing the config file (introduced in #43) fails if config_file_path only contains a filename but no directories (similar to timvink/mkdocs-table-reader-plugin#16). Replacing an empty result of os.dirname should avoid this.

@pawamoy
Copy link
Member

pawamoy commented Nov 19, 2022

Argh, I guess I botched a release. Fine, let's fix that again.
Thanks for the report and fix 🙂

@pawamoy pawamoy merged commit 34cfa4b into mkdocstrings:master Nov 19, 2022
@pawamoy
Copy link
Member

pawamoy commented Nov 19, 2022

v0.8.2 released 😓

@hofaflo
Copy link
Contributor Author

hofaflo commented Nov 19, 2022

Thanks for the super quick fix and release! :)

@hofaflo hofaflo deleted the fix-chdir branch November 19, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants