Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Enable https:// for 'image' in the Authentication Hash #36

Closed
Mattyx opened this Issue Mar 11, 2012 · 0 comments

Comments

Projects
None yet
2 participants

Mattyx commented Mar 11, 2012

I have modified the code of the Facebook Strategy class to use https:// or http:// for the URL of the Facebook user image inside the Authentication hash.
I use a new boolean parameter (eg. :secure) passed on provider declaration:

provider :facebook, ENV['FACEBOOK_KEY'], ENV['FACEBOOK_SECRET'], :secure => true

The code of the Facebook Strategy class that I've changed is in this gist: https://gist.github.com/2014580

I hope that you can implement something similar for the next version of the gem, it's useful (IMHO) for websites that use SSL to avoid browser complaints about inclusion of unsafe resources! ;)

@mkdynamic mkdynamic closed this in c06341e Mar 11, 2012

@ghost ghost assigned mkdynamic Mar 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment