Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New DialogFX #4

Merged
merged 19 commits into from Nov 22, 2014
Merged

New DialogFX #4

merged 19 commits into from Nov 22, 2014

Conversation

rafaelcn
Copy link
Contributor

I would like to pull my fork of the DialogFX pop up, I redesigned the GUI with a .fxml file, and also updated the icons to GTK. You can see an image of the pop up below (The language is portuguese-br if you are curious 😄).
dialogfx_popup

Regards,
Rafael C. Nunes.

@mkheck
Copy link
Owner

mkheck commented Oct 15, 2014

Hola Rafael,

I like this! I won't have a chance to check things out and pull in the
code for the next few days, but it's at the top of my list for early next
week. Looks great!

All the best to you, and thanks!
Mark

On Wed, Oct 15, 2014 at 6:43 PM, Rafael C. Nunes notifications@github.com
wrote:

I would like to pull my fork of the DialogFX pop up, I redesigned the GUI
with a .fxml file, and also updated the icons to GTK. You can see an image
of the pop up, follow the link.
[image: dialogfx_popup]
https://cloud.githubusercontent.com/assets/3271143/4655527/008b5ce0-54c5-11e4-8c36-8c4d79a8a4e7.png

Regards,

Rafael C. Nunes.

You can merge this Pull Request by running

git pull https://github.com/rafaelcn/DialogFX master

Or view, comment on, or merge it at:

#4
Commit Summary

  • addded a travis CI integration
  • Updated travis.yml
  • Removed old icons to place new GTK icons
  • Placed GTK icons
  • Placed the new popup.
  • Modified DialogFX's classes to adapt the new GUI and added a WARNING
    type to the popup.
  • Added a controller for the DialogFX .fxml file, though it's not
    working one hundred per cent.
  • deleted to place the new renamed icons
  • icons renamed
  • Modified the strings in the case statement to correct icons^Cames
  • I Forgot to change the default case, but it is already fixed. :)
  • Now everything is working as expected, have fun. :)
  • README updated.

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#4.

@rafaelcn
Copy link
Contributor Author

I recommend that the warning icon should be drawn from zero (The actual one looks like an error icon).

Regards,
Rafael C. Nunes.

mkheck added a commit that referenced this pull request Nov 22, 2014
@mkheck
Merge pull request #4 from rafaelcn/master
471693e 
New DialogFX version, updates courtesy of Rafael Nunes!
@mkheck mkheck merged commit 471693e into mkheck:master Nov 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafaelcn @mkheck