Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for variable-length messages #8

Merged
merged 1 commit into from Jan 25, 2022
Merged

Allow for variable-length messages #8

merged 1 commit into from Jan 25, 2022

Conversation

fcanas
Copy link
Contributor

@fcanas fcanas commented Jan 25, 2022

No description provided.

@fcanas fcanas requested a review from mkj-is as a code owner January 25, 2022 02:15
@fcanas
Copy link
Contributor Author

fcanas commented Jan 25, 2022

This should address #8.

@fcanas
Copy link
Contributor Author

fcanas commented Jan 25, 2022

I'm happy to rework this. Let me know what you'd like to be different.

@mkj-is
Copy link
Owner

mkj-is commented Jan 25, 2022

Thanks for your extensive work on this! I might explore your idea to store the array of bytes in the message and then release a new version of the library.

@mkj-is mkj-is merged commit f945cf6 into mkj-is:main Jan 25, 2022
@mkj-is mkj-is linked an issue Jan 25, 2022 that may be closed by this pull request
MIDI Messages are not all 3 bytes #7
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkj-is mkj-is mkj-is approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MIDI Messages are not all 3 bytes
2 participants
@fcanas @mkj-is