Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linking with system libtom #28

Closed
wants to merge 1 commit into from
Closed

fix linking with system libtom #28

wants to merge 1 commit into from

Conversation

fperrad
Copy link
Contributor

@fperrad fperrad commented Apr 1, 2016

in all case, we want link with 'libtomcrypt' and 'libtommath' (in this sequence).

in bundled case, just add the specific location of these libraries

in all case, we want link with 'libtomcrypt' and 'libtommath' (in this sequence).

in bundled case, just add the specific location of these libraries
@mkj
Copy link
Owner

mkj commented Jun 3, 2017

I think 7ab8f61 sorts this out a different way? Let me know if I'm missing something. Thanks.

@mkj mkj closed this Jun 3, 2017
@fperrad
Copy link
Contributor Author

fperrad commented Jun 3, 2017

sorry, still failing (tested with Buildroot, see https://github.com/fperrad/br/commits/libtom)

/home/user/build/linaro/host/usr/bin/arm-linux-gnueabihf-gcc  -o dropbearmulti dbmulti.o atomicio.o bignum.o buffer.o circbuffer.o cli-agentfwd.o cli-auth.o cli-authinteract.o cli-authpasswd.o cli-authpubkey.o cli-channel.o cli-chansession.o cli-kex.o cli-main.o cli-runopts.o cli-session.o cli-tcpfwd.o common-algo.o common-channel.o common-chansession.o common-kex.o common-runopts.o common-session.o compat.o crypto_desc.o curve25519-donna.o dbhelpers.o dbrandom.o dbutil.o dh_groups.o dropbearconvert.o dropbearkey.o dss.o ecc.o ecdsa.o fake-rfc2553.o gendss.o genrsa.o gensignkey.o keyimport.o list.o listener.o loginrec.o ltc_prng.o netio.o packet.o process-packet.o progressmeter.o queue.o rsa.o scp.o scpmisc.o signkey.o sshpty.o svr-agentfwd.o svr-auth.o svr-authpam.o svr-authpasswd.o svr-authpubkey.o svr-authpubkeyoptions.o svr-chansession.o svr-kex.o svr-main.o svr-runopts.o svr-service.o svr-session.o svr-tcpfwd.o svr-x11fwd.o tcp-accept.o termcodes.o -ltommath -ltomcrypt -lutil -lz  -lcrypt
/home/user/build/linaro/host/usr/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libtomcrypt.a(ltm_desc.o): In function `write_radix':
ltm_desc.c:(.text+0xab4): undefined reference to `mp_toradix'
/home/user/build/linaro/host/usr/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libtomcrypt.a(ltm_desc.o): In function `get_int':
ltm_desc.c:(.text+0xcac): undefined reference to `mp_get_int'
/home/user/build/linaro/host/usr/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libtomcrypt.a(ltm_desc.o): In function `neg':
ltm_desc.c:(.text+0xd8c): undefined reference to `mp_neg'
collect2: error: ld returned 1 exit status

-ltomcrypt must been always before -ltommath

@armcc
Copy link
Contributor

armcc commented Jun 6, 2017

Did you regenerate the configure script after patching configure.ac ?

@fperrad
Copy link
Contributor Author

fperrad commented Jun 6, 2017

You are right. I missed the DROPBEAR_AUTORECONF = YES in Buildroot.
The issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants