Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any reason that DESELECT related MessageType enums are commented out? #39

Closed
synecc opened this issue Nov 22, 2019 · 1 comment

Comments

@synecc
Copy link

synecc commented Nov 22, 2019

In lastest version:

public enum MessageType : byte
    {
        DataMessage       = 0b0000_0000,
        SelectRequest     = 0b0000_0001,
        SelectResponse    = 0b0000_0010,
        //Deselect_req      = 0b0000_0011,
        //Deselect_rsp      = 0b0000_0100,
        LinkTestRequest   = 0b0000_0101,
        LinkTestResponse  = 0b0000_0110,
        //Reject_req        = 0b0000_0111,
        SeperateRequest   = 0b0000_1001
    }

In previous versions:

enum MessageType : byte {
        DataMessage = 0,	    // 00000000
        SelectRequest = 1,		// 00000001	ReplyExpected
        SelectResponse = 2,		// 00000010
        //Deselect_req = 3,	    // 00000011	ReplyExpected
        //Deselect_rsp = 4,	    // 00000100
        LinkTestRequest = 5,	// 00000101	ReplyExpected
        LinkTestResponse = 6,	// 00000110
        //Reject_req = 7,	    // 00000111
        SeperateRequest = 9	    // 00001001
    }

Is there any specific reason or I could just implement them?

@mkjeff
Copy link
Owner

mkjeff commented Jul 23, 2021

coz I don't how to react to this. could you provide the scenario?

@mkjeff mkjeff closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants