Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimatch from 0.x to 3.x #28

Closed
wants to merge 1 commit into from

Conversation

gilligan
Copy link

@gilligan gilligan commented Jul 8, 2016

I noticed a warning during the npm install of our app relating to minimatch:

npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

istanbul f.ex. depends on an old fileset version and there is a ticket already for replacing fileset entirely that I also contributed to: gotwarlost/istanbul#638 - That being said I wonder if you would be willing to accept this PR and release a 0.2.1 version of fileset to get rid of the old minimatch version right away.

@mklabs
Copy link
Owner

mklabs commented Jul 9, 2016

Hi @gilligan,

Please update your fileset dependency to 2.0.x, it has been fixed recently.

@mklabs mklabs closed this Jul 9, 2016
@mklabs
Copy link
Owner

mklabs commented Jul 9, 2016

And let me know if it works correctly, and as expected. I didn't updated the documentation but the API surface remained the same.

@gilligan
Copy link
Author

gilligan commented Jul 9, 2016

@mklabs i think you did not get what I meant ;) if fileset was a direct dependency under my control I would obviously just update. However various packages depend on old fileset 0.2.x and i can't update those obviously ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants