BUG: SQLGetData called with SQL_C_BINARY type errors for SQL_NUMERIC/DECI #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failure in GetDataString for SQL_NUMERIC/SQL_DECIMAL
This came up when adding an output converter for SQL_NUMERIC/SQL_DECIMAL-- resulted in failure in SQLGetData in PostgreSQL ODBC and also the Netezza ODBC drivers. Haven't tested any others.
Generally speaking, when querying large datasets, conversion to Decimal and converting back to float (especially for putting data in NumPy arrays) is a major bottleneck. Can you think of any strategies to get around this?
I'd be happy to add a test case or two for this if you'd like.
I also note you have CRLF issues in the pyodbc repo, assume you're developing on Windows?