Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - add "Import by wave id" feature. #28

Closed
GoogleCodeExporter opened this issue Aug 6, 2015 · 7 comments
Closed

Suggestion - add "Import by wave id" feature. #28

GoogleCodeExporter opened this issue Aug 6, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

Sometimes you just want to import a wave fast by wave id. It would be great to 
have such an option IMO.

Original issue reported on code.google.com by vega113 on 15 Dec 2011 at 7:56

@GoogleCodeExporter
Copy link
Author

Good idea.  It should be possible to add another form to 
ImportOverviewFragment.gxp, something like

                  <form method='post' action='import'>
                    <input type='hidden' name='action' value='importwave'/>
                    <input name='instance' value='XXX'/>
                    <input name='waveid' value='YYY'/>
                    <input type='hidden' name='token' expr:value='token'/>
                    <input type='submit' value='import'/>
                  </form>

I don't think ImportOverviewHandler even needs to change.  Feel free to play 
around with this and send a patch.

Original comment by oh...@google.com on 15 Dec 2011 at 8:05

  • Changed state: Accepted
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

Yeah, I can try. But is there an easy way to display the /import page while 
running the app in local dev mode wihtout being asked to enable pictures?

Original comment by vega113 on 15 Dec 2011 at 12:55

@GoogleCodeExporter
Copy link
Author

I think you do need to click "enable" and go through the OAuth authorization, 
since import depends on OAuth to access your waves.  If the OAuth pop-up gives 
you errors, go to the Google API console and make sure 
http://localhost:8080/authenticate is in the list of authorized redirect URIs 
as described in http://code.google.com/p/walkaround/wiki/RunningTheCode .

Original comment by oh...@google.com on 15 Dec 2011 at 6:32

@GoogleCodeExporter
Copy link
Author

I ended up with something like this:
https://code.google.com/r/vega113-wavewa/source/detail?r=4a7f2617be71c95e51ed50d
1cc82623bd42356d8&name=waveidimport
Probably, could add some javascript in order to avoid duplicating the instance 
selection code, but wasn't sure it worth the effort.

Original comment by vega113 on 17 Dec 2011 at 8:35

@GoogleCodeExporter
Copy link
Author

When I tried
git clone https://code.google.com/r/vega113-wavewa/
I did not get that change.  Which repository is it in?  Or is it not committed?

Original comment by oh...@google.com on 19 Dec 2011 at 8:40

@GoogleCodeExporter
Copy link
Author

It's in waveidimport branch.

Original comment by vega113 on 19 Dec 2011 at 9:10

@GoogleCodeExporter
Copy link
Author

Found it, thanks.  I pulled from your branch, which means your tweaks to 
.project and .classpath are now also integrated.

Thanks for implementing this feature!

Original comment by oh...@google.com on 19 Dec 2011 at 10:37

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant