Remove trigger from items #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created new PR smarthomeNG/smarthome#51 in new project and will close this issue now. Thanks for your great application! |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation about item triggers offers only methods to add triggers to an item (e.g. update trigger or logic trigger).
This patch adds to methods to remove the trigger again:
remove_method_trigger()remove_logic_trigger()This way a logic developer (for example) has the posibility to dynamically register a trigger and unregister them later again if the logic completes.
Maybe there are other situation where unregistering a trigger is useful (e.g. when reloading some configuration - which is currently not really supported, but may be supported in future versions).