Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug on uota.py line 183. #5

Closed
beyonlo opened this issue Sep 22, 2022 · 1 comment
Closed

Possible bug on uota.py line 183. #5

beyonlo opened this issue Sep 22, 2022 · 1 comment

Comments

@beyonlo
Copy link

beyonlo commented Sep 22, 2022

Hi, thanks for the great project!

I found a problem in line 183:
not quiet and log.debug(f'creating directory {file_name} ... ', end='')

If I change that line to this below works:
not quiet and log.debug(f'creating directory {file_name} ... ')

Complete log error:

>>> import uota
WARNING: ucertpin package not found, certificate pinning is disabled
>>> uota.check_for_updates()
WARNING: local version information missing, ignoring it
INFO: new version 2.0.1 is available
True
>>> uota.install_new_firmware()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "uota.py", line 183, in install_new_firmware
TypeError: unexpected keyword argument 'end'
>>> 

Is that a really bug or am I doing something wrong?

Thank you.

mkomon pushed a commit that referenced this issue Jan 10, 2023
Removed 'end' parameter from logging call.
@mkomon
Copy link
Owner

mkomon commented Jan 10, 2023

Hi,

that was indeed a bug and not a problem on your end. It's fixed by #4.

Thank you for pointing it out.

@mkomon mkomon closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants