You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re that broken Travis build - it's a one-line workaround to get around that failure in PHP 5.5, but I think we should just support 5.6+. 5.5 has been unsupported for almost 2 years.
We had a much simpler algorithm for detecting character substitutions,
however it failed when dealing with certain characters. As such, this
change just ports upstream's logic, with only minor changes.
This affected passwords where there was a SpatialMatch that did
encompass the first character, and the first character in the
password was a shifted character
It's impossible for us to match all browsers exactly (since the way that
elements that compare as equal as sorted is implementation-defined in
JavaScript), but this gets us pretty close.
@mkopinsky I think this is done in terms of matching upstream and is ready to merge. I've tested against the top 1 million passwords from the rockyou password list and haven't found any further discrepancies.
Can you add the scripts or documentation on how you did that comparison? I think that would be a useful tool for the future when/if upstream releases a new version.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clamburger
force-pushed
the
match-upstream
branch
from
With these last few changes we should now match upstream!