Skip to content
This repository has been archived by the owner on Feb 10, 2021. It is now read-only.

Add azerty keyboard graph #8

Closed
wants to merge 4 commits into from
Closed

Conversation

Zeuh
Copy link

@Zeuh Zeuh commented Dec 30, 2018

  • add support into python JSON graph builder
  • add support to SpatialMatch class
  • add unit tests

Signed-off-by: Yann 'Ze' Richard <ze@nbox.org>
Signed-off-by: Yann 'Ze' Richard <ze@nbox.org>
Signed-off-by: Yann 'Ze' Richard <ze@nbox.org>
@mkopinsky
Copy link
Owner

Thanks for your contribution!

My intention with this repo is to directly match the upstream Dropbox library's behavior. Although adding support for azerty logically makes sense, that should be done in the upstream library before I would want to add it here.

dropbox/zxcvbn#190 is an issue opened by the original author to add azerty support, which leads me to think they may be open to a PR along those lines. I'm not fluent enough in coffeescript to do that, but if you can get this feature added upstream I'd happily merge this here.

@Zeuh
Copy link
Author

Zeuh commented Jan 1, 2019

Hi,

I think there is not mush hope for rapid with original dropbox project when I read old PR or question in issues :

I will wait for the changes announced before spending time on a lib that I would not use. I prefer calling a custom API that use the zxcvbn PHP project with support for my language.

Thanks for replying so quickly and happy new year :)

@Zeuh Zeuh closed this Jan 1, 2019
@mkopinsky
Copy link
Owner

That's very interesting to hear that he's planning on removing the coffeescript dependency. I hope that doesn't mean a lot of breaking changes! I agree, I wouldn't spend a lot of time on a coffeescript PR at this point in time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants