check if result is empty issue fixed

mkorkmaz · Feb 19, 2021 · 3a12baa · 3a12baa
1 parent 8d7263f
commit 3a12baa
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/src/ReJSON/Command/Get.php b/src/ReJSON/Command/Get.php
@@ -22,7 +22,7 @@ private function __construct(
         $this->arguments = [$key];
         $this->arguments = array_merge($this->arguments, $paths);
         $this->responseCallback = function ($result) {
-            if ($result !== null) {
+            if (!empty($result)) {
                 return json_decode($result);
             }
             return null;

diff --git a/src/ReJSON/Command/GetArray.php b/src/ReJSON/Command/GetArray.php
@@ -22,7 +22,7 @@ private function __construct(
         $this->arguments = [$key];
         $this->arguments = array_merge($this->arguments, $paths);
         $this->responseCallback = function ($result) {
-            if ($result !== null) {
+            if (!empty($result)) {
                 return json_decode($result, (bool) JSON_OBJECT_AS_ARRAY, 512, JSON_THROW_ON_ERROR);
             }
             return null;

diff --git a/tests/Module/ReJSONTest.php b/tests/Module/ReJSONTest.php
@@ -174,7 +174,6 @@ public function shouldRunReJSONCommandMgetSuccessfully(): void
         $this->reJsonModule->set('test', '.baz', 'qux');
         $this->reJsonModule->set('test', '.baz', 'quux', 'XX');
         $this->reJsonModule->set('test2', '.', ['foo2' => 'bar2']);
-        var_dump($this->reJsonModule->mgetArray('test', 'test2', '.'));
     }
 
     /**