After reading typeorm#5125, it seems the consensus was to return an e…

…mpty object after a JSON parse failure
mkornatz · Oct 9, 2020 · 6f8146e · 6f8146e
1 parent a087871
commit 6f8146e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/util/DateUtils.ts b/src/util/DateUtils.ts
@@ -178,7 +178,7 @@ export class DateUtils {
         try {
             return JSON.parse(value);
        } catch (err) {
-            return null;
+            return {};
        }
     }
 

diff --git a/test/github-issues/4440/issue-4440.ts b/test/github-issues/4440/issue-4440.ts
@@ -25,7 +25,7 @@ describe("github issues > #4440 simple-json column type throws error for string
         await repo.save(post);
         const postFound = await repo.findOne(1);
         postFound!.id.should.eql(1);
-        postFound!.jsonField.should.eql("");
+        postFound!.jsonField.should.eql({});
     })));
 
     it("should correctly add retrieve simple-json field with some value", () =>