typing-utils seems to be required for all python versions

mkorpela · Apr 24, 2021 · d90d1be · d90d1be
1 parent a1ec3c5
commit d90d1be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/overrides/enforce.py b/overrides/enforce.py
@@ -2,8 +2,7 @@
 import inspect
 from inspect import Parameter, Signature
 from typing import Callable
-
-import typing_utils
+from typing_utils import issubtype
 
 
 def ensure_compatible(
@@ -68,7 +67,7 @@ def ensure_all_args_defined_in_sub(super_sig, sub_sig):
             elif (
                     super_param.annotation != Parameter.empty
                     and sub_param.annotation != Parameter.empty
-                    and not typing_utils.issubtype(super_param.annotation, sub_param.annotation)
+                    and not issubtype(super_param.annotation, sub_param.annotation)
             ):
                 raise TypeError(
                     f"`{name} must be a supertype of `{super_param.annotation}`"
@@ -114,7 +113,7 @@ def ensure_return_type_compatibility(super_sig, sub_sig):
     if (
             super_sig.return_annotation != Signature.empty
             and sub_sig.return_annotation != Signature.empty
-            and not typing_utils.issubtype(sub_sig.return_annotation, super_sig.return_annotation)
+            and not issubtype(sub_sig.return_annotation, super_sig.return_annotation)
     ):
         raise TypeError(
             f"`{sub_sig.return_annotation}` is not a `{super_sig.return_annotation}`."

diff --git a/setup.py b/setup.py
@@ -23,7 +23,7 @@
       author_email=address,
       url='https://github.com/mkorpela/overrides',
       packages=find_packages(),
-      install_requires=['typing;python_version<"3.5"', 'typing-utils>=0.0.3;python_version<"3.8"'],
+      install_requires=['typing;python_version<"3.5"', 'typing-utils>=0.0.3'],
       license='Apache License, Version 2.0',
       keywords=['override', 'inheritence', 'OOP'],
       classifiers=[