Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 2(.7 at least) support for EnforceOverrides #28

Closed
wants to merge 6 commits into from

Conversation

tmasek
Copy link

@tmasek tmasek commented Oct 29, 2019

duplicate enforce.py file in python 2(.7) syntax: super() with two arguments, and __metaclass__ attribute (instead of class def kwarg)

also modified test_enforce.py to always run (not just for python version 3+)

@tmasek
Copy link
Author

tmasek commented Oct 29, 2019

hmm, something seems off in my testing. keep getting the error that says a class overrides a method but is missing the @overrides decorator, even though it's there in the code. maybe wait on this PR until I get to the bottom of it..

@tmasek
Copy link
Author

tmasek commented Feb 5, 2020

sorry, didn't look at this at all during the holidays. looks like in my use case, the failures were all caused by @classmethods; it also looks like that's been fixed (#30), so I think this python 2.7 back port should be good to go

@mkorpela
Copy link
Owner

Unfortunately not supporting Python 2 anymore

@mkorpela mkorpela closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants