Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set width to auto to float table header #299

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Conversation

cantin
Copy link
Contributor

@cantin cantin commented Apr 12, 2016

With css rule "table { width: 100%; }" and long paragraph in th cell, first few rows would be covered by floating header.

Fiddle: http://jsfiddle.net/nrjqf44e/3/ (first row is invisible.)

@mkoryak
Copy link
Owner

mkoryak commented Apr 19, 2016

sorry,
not seeing this http://jsfiddle.net/nrjqf44e/4/

what am i looking for? no rows are covered up. I am on osx/chrome

@cantin
Copy link
Contributor Author

cantin commented Apr 19, 2016

Hi, thanks for reply.

Viewport must be width enough to let long paragraph become one line when calculating header height,
So the calculated header height (one line) is less than actual header height (two lines).

Attached gif and updated fiddle:

out

http://jsfiddle.net/nrjqf44e/5/

@mkoryak mkoryak merged commit ccf2062 into mkoryak:master Apr 20, 2016
@mkoryak
Copy link
Owner

mkoryak commented Apr 20, 2016

I see, weird that I've never encountered that before. Thanks for the fix!

mkoryak added a commit that referenced this pull request Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants