Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ipad retina table width issue #361

Merged
merged 1 commit into from
Mar 15, 2017

Conversation

adam187
Copy link
Contributor

@adam187 adam187 commented Mar 15, 2017

I had issue on iPad retina where table header was not aligned (had same width) with table.

screen shot 2017-03-15 at 09 49 12

Reason for that was difference between table sizing columns and table width itself (from calculation).

screen shot 2017-03-15 at 09 49 29

Table sizing cols had fractions, but for table width calculation offsetWidth was used and it always return integers.

Switching from .offsetWidth to getOffsetWidth() for table width calculation solved problem.

getOffsetWidth() is using getBoundingClientRect() which return width with fractions.

@mkoryak mkoryak merged commit 0349558 into mkoryak:master Mar 15, 2017
@mkoryak
Copy link
Owner

mkoryak commented Mar 15, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants