Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set header size on reflow #399

Merged
merged 3 commits into from
Jan 26, 2018
Merged

set header size on reflow #399

merged 3 commits into from
Jan 26, 2018

Conversation

ameily
Copy link
Contributor

@ameily ameily commented Jan 25, 2018

I am seeing an issue where I'm calling floatThead('reflow'), which is causing a <th> in the header to wrap and resize. After this, the first row of the <tbody> is cut off. I've made a jsfiddle that matches what I'm doing locally but I cannot reproduce there. It happens occasionally on a project I'm working on locally.

The fix appears to be pretty straightforward: change the call to repositionFloatContainer for reflow events to also set the header height.

@mkoryak
Copy link
Owner

mkoryak commented Jan 26, 2018

Looks ok to me. You didn't generate dist, so it won't be in the minified version until I cut the next release or someone else submits a PR with it

@ameily
Copy link
Contributor Author

ameily commented Jan 26, 2018

I built the dist versions. I had to use the uglify-js package because ulgifyjs has been deprecated.

@mkoryak
Copy link
Owner

mkoryak commented Jan 26, 2018

Do you mind also updating package.json deps as well?

@ameily
Copy link
Contributor Author

ameily commented Jan 26, 2018

Done.

@mkoryak
Copy link
Owner

mkoryak commented Jan 26, 2018

Thanks!

@mkoryak mkoryak merged commit 487d05c into mkoryak:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants