Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an 'overflow' option to govern floatContainer CSS #404

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

martin-cowie
Copy link
Contributor

Hi Misha,

I'm sympathetic to your plea for 'no more options!', however I cannot otherwise see an (elegant) means of achieving this:

Use case: Embedding bootstrap dropdowns within the table header clips the menus to the size of floatContainer because the CSS overflow attribute is set to hidden.

Solution: Allow the user to set the overflow attribute via the options Object passed to floatThead.

Mitigation: By default behaviour remains unchanged.

Congratulations on the kid. I have two. It's quite the rollercoaster ride.

By default behaviour remains unchanged.
@mkoryak
Copy link
Owner

mkoryak commented Feb 13, 2018

Hmmmm, ok this has come up before in the past. I will merge this, but can you rename the option to floatContainerOverflow so that is it a little more self-documenting ?

@martin-cowie
Copy link
Contributor Author

martin-cowie commented Feb 14, 2018 via email

@mkoryak mkoryak merged commit 4302c2f into mkoryak:master Feb 16, 2018
@martin-cowie
Copy link
Contributor Author

martin-cowie commented Feb 26, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants