Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header not disappearing after table out of view #82

Merged
merged 1 commit into from
Apr 28, 2014

Conversation

clyfe
Copy link
Contributor

@clyfe clyfe commented Apr 27, 2014

When using with useAbsolutePositioning: false and given scrollContainer like this:

$('.floathead]').floatThead(
  scrollContainer: ($tbl) -> $tbl.closest($tbl.data('scroll'))
  useAbsolutePositioning: false
)

When using with useAbsolutePositioning: false and given scrollContainer like this:

    $('.floathead]').floatThead(
      scrollContainer: ($tbl) -> $tbl.closest($tbl.data('scroll'))
      useAbsolutePositioning: false
    )
@clyfe
Copy link
Contributor Author

clyfe commented Apr 27, 2014

Fiddle reproducing issue: http://jsfiddle.net/88G7w/

@mkoryak
Copy link
Owner

mkoryak commented Apr 28, 2014

What is the usecase of having the scrolling container take up 100% of the page height? Wouldn't it make more sense to use window scrolling at that point and not use a scroll container at all? Like so:
http://jsfiddle.net/88G7w/1/

Or is it the case that the .scroll div is in your html already for some other perfectly good reason, and this plugin does not work because of that? If so, what is that reason ?

mkoryak added a commit that referenced this pull request Apr 28, 2014
@clyfe
Copy link
Contributor Author

clyfe commented Apr 28, 2014

It is the case that the .scroll div is in my html already for some other perfectly good reason.
That reason is I have an off-canvas menu implemented kinda like here on both left and right with a fixed right.

Even if the scroll container would not be 100% of the page height the issue would still stand.

@mkoryak
Copy link
Owner

mkoryak commented Apr 28, 2014

Ok, sounds good. Ill merge it soon

mkoryak added a commit that referenced this pull request Apr 28, 2014
Fix header not disappearing after table out of view
@mkoryak mkoryak merged commit 73b8bf0 into mkoryak:master Apr 28, 2014
mkoryak added a commit that referenced this pull request Apr 28, 2014
mkoryak added a commit that referenced this pull request Apr 28, 2014
@mkoryak
Copy link
Owner

mkoryak commented Apr 28, 2014

Thanks for the code man 👍

@clyfe
Copy link
Contributor Author

clyfe commented Apr 29, 2014

Sweet. Can you do a bower release soon?

mkoryak added a commit that referenced this pull request Apr 30, 2014
* gh-pages:
  generate dist for #82
  testcase for #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants