-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't support rounded edges (or other glare props) #27
Comments
Actually, even if I add the following:
There seems to be a bug in Safari both on desktop and iOS that causes square corners to show momentarily, before disappearing. Not sure why this is? I'll have a look into it further to see if a CSS bug? |
Actually, that can be fixed by adding the |
Hi @LucidNinja thanks for the detailed bug report and provided possible solution(s) 🚀 |
Ok I can give it a go! |
…children The border radius of the glare can now be the same as the child component. This previously presented as an issue when the glare color was different to the background color of the app. fix mkosir#27
Hey @mkosir - adding the GlareBorderRadius prop to the styleGlareWrapper would have required me to change the constructor (from what I can see), so I created a private method inside Glare.tx and ran it during the render method. Not sure if that's the best way to tackle it, but it works. Let me know if you have any feedback. See #28 |
Hey @LucidNinja, thanks for the PR, it looks great, I already merged it and created new release |
🐛 Issue/Bug Report Template
Describe the bug
If using rounded edges for the component and there is a dark background, the tilt component doesn't honour the rounded edges.
To Reproduce
Steps to reproduce the behavior:
Exactly as in the Glare demo here: https://mkosir.github.io/react-parallax-tilt/?path=/story/react-parallax-tilt--glare-effect, but with a dark background.
Expected behavior
It would be nice to be able to pass props down to the Glare Element (unless this is already possible and not clearly documented?). Or do you suggest just using CSS to override the
glare-wrapper
class?Link to demo (required)
https://codesandbox.io/s/recursing-perlman-c09t3?fontsize=14&hidenavigation=1&theme=dark
Issues without a reproduction link are likely to stall.
Code snippets
As above or Codesandbox link.
Environment
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: