Remove zfill of version number on testrun name generation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
force-pushed
the
remove-zfill-version
branch
from
6995a68
to
b40a8e7
Compare
mshriver
force-pushed
the
remove-zfill-version
branch
from
b40a8e7
to
59a02d3
Compare
mshriver
commented
Nov 12, 2018
mshriver
force-pushed
the
remove-zfill-version
branch
2 times, most recently
from
ca42726
to
c4952b0
Compare
Refactor ostriz_tools.get_testrun_id slightly to use packaging.version.Version for string parsing Update ostriztools test
mshriver
force-pushed
the
remove-zfill-version
branch
from
c4952b0
to
a0ddaf8
Compare
mkoura
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFME QE would like to stop zfilling testrun ID's last build number, and instead use the version number itself (with '_' replacement) for the testrun ID. Since this was hardcoded, when we tried to upload results to polarion it was automatically adding a new testrun with a double-zero ID.
@mkoura I'm interested in your thoughts on the impact here, and if I should instead build up some logic around this lookup for non-zfill testrun ID's.