Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD #116 show background dependent on level #121

Merged
merged 1 commit into from
Feb 11, 2020
Merged

ADD #116 show background dependent on level #121

merged 1 commit into from
Feb 11, 2020

Conversation

knoffi
Copy link
Collaborator

@knoffi knoffi commented Feb 11, 2020 •
edited by mkraenz
Loading

Closes #116

mkraenz
mkraenz approved these changes Feb 11, 2020
View reviewed changes
Copy link
Owner

@mkraenz mkraenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkraenz mkraenz temporarily deployed to fursorger-game February 11, 2020 17:28 Inactive
@codecov
Copy link

codecov bot commented Feb 11, 2020 •
edited
Loading

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files           1        1           
  Lines          18       18           
  Branches        5        5           
=======================================
  Hits            6        6           
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b556714...7c9b386. Read the comment docs.

@knoffi knoffi merged commit c899d3c into master Feb 11, 2020
@knoffi knoffi deleted the 114-As-a-Level-Designer-I-want-a-property-for-the-background-image-/-theme-in-the-level-json branch February 11, 2020 17:59
@mkraenz mkraenz changed the title ADD #114 show background dependent on level ADD #116 show background dependent on level Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkraenz mkraenz mkraenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a Level Designer I want a property for the background image / theme in the level json
2 participants
@knoffi @mkraenz