Add insertion API and a few other things #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tag is used with "translate" messages to allow substituting variables within the message
Closed
mkremins
added a commit
that referenced
this pull request
Jan 7, 2015
Add insertion API and a few other things
|
Looks good, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would resolve issue #40 by adding the requested API (and the necessary methods for serialization/deserialization). By testing within Minecraft, I concluded that only plaintext can be used with the insertion API and not other JSON messages.
In addition, support for the
withJSON tag is added. This tag can only be used in conjunction with atranslatetext tag. It will supply substitutions, potentially formatted, for the variables within the language-specific strings.