Autofix Ruby code style #64
Conversation
Frozen String literal comment was ignored for now, because it let's the test fail (String.strip! is used in installer).
lib/jar_dependencies.rb
Outdated
| urls = jars_lock_from_class_loader | ||
| if urls and urls.size > 0 | ||
| if !urls&.empty? |
There was a problem hiding this comment.
@mkristian Yeah, right? ;) But it’s valid syntax since Ruby v2.3.0 and in JRuby since v9.1 (see "safe navigation operator" in jruby/jruby#3479). But I figure it will break for a Ruby language level below v2.3.0, so, I’ll change it back.
There was a problem hiding this comment.
sorry I did not know this syntax :) but let's stick to older syntax for older jruby
lib/jars/installer.rb
Outdated
| result << dep if dep && dep.scope == :runtime | ||
| File.read(file).each_line do |line| | ||
| dep = Dependency.new(line) | ||
| result << dep if dep&.scope == :runtime |
There was a problem hiding this comment.
Same safe navigation operator syntax here (and below in the same file).
The save navigation operator (&.) is supported since Ruby v2.3.0 (JRuby v9.1.0.0, see jruby/jruby#3479). So these autocorrection would fail for lower versions, like 9.0.5.0, which is e.g. used by Travis CI.
|
Hm, looks like the |
Multiline HEREDOC was introduced in Ruby v2.3.0. This allows to support JRuby with Ruby language level < v2.3.0 (JRuby < v9.1.0.0).
__dir__ was introduced in Ruby v2.0.0.
The latest Rubocop only works with Ruby language levels <=2.1. If we wanted to support 1.9 we would have to use Rubocop v0.41.2. I just disabled the Ruby >1.9 configs in .rubocop.yml in order to be able to use a recent Rubocop version.
|
@mkristian I guess I covered all compatibility issues. Still, there are two settings (openJDK7 & 8 for I can’t really find anything syntax-related hints. So, any ideas why these fail? |
|
yes, they are not related to the any syntax change. great that you took up the pain to make the patch working on older version of jruby as well. let me see if I can fix/work this bouncy-castle problem. |
Fixes #63.
Using the added config to autocorrect the code base with Rubocop.