Don't make rolling noises when sending non-rolling character items to the chat #68
Assignees
Comments
hiddenkrypt
added a commit
to hiddenkrypt/sta
that referenced
this issue
May 28, 2022
…he same as regular items and call on actor.js rollGenericItem. Changed Actor.js to correctly use characterweapon items with roll.js performWeaponRoll(). Heavily overhauled roll.js. Created new helper functions to simplify repeated code, including generating strings from challenge dice, which is now down in multiple places. performWeaponRoll() now generates a nice weapon block for chat using the genericItemTemplate, and also generates the damage roll to append to it. I think it looks quite slick. The genericItemTemplate() now takes an itemId string and appends it to an html element as an attribute named data-item-id to enable functions from the Maestro module. i18n strings had to be changed for this new weapon roll display, this was done in a previous commmit. Damage for weapon rolls is computed directly at roll time from the weapon's base damage stat and the owner's security stat rather than scraping the number off the character sheet HTML. All rolls are now asynchronous, to match the upcoming changes in FoundryVTT. This will prevent depreciation warnings in the console, and breaking change headaches when the new version of FVTT comes out. All files have been fixed to pass eslint. This commit addresses outstanding bug/issues mkscho63#36, mkscho63#67, and mkscho63#68
mkscho63
added a commit
that referenced
this issue
Jul 25, 2022
* adding nationalization strings and changes to support new weapon chat message * Changed sheet scripts to treat characterweapons and starshipweapons the same as regular items and call on actor.js rollGenericItem. Changed Actor.js to correctly use characterweapon items with roll.js performWeaponRoll(). Heavily overhauled roll.js. Created new helper functions to simplify repeated code, including generating strings from challenge dice, which is now down in multiple places. performWeaponRoll() now generates a nice weapon block for chat using the genericItemTemplate, and also generates the damage roll to append to it. I think it looks quite slick. The genericItemTemplate() now takes an itemId string and appends it to an html element as an attribute named data-item-id to enable functions from the Maestro module. i18n strings had to be changed for this new weapon roll display, this was done in a previous commmit. Damage for weapon rolls is computed directly at roll time from the weapon's base damage stat and the owner's security stat rather than scraping the number off the character sheet HTML. All rolls are now asynchronous, to match the upcoming changes in FoundryVTT. This will prevent depreciation warnings in the console, and breaking change headaches when the new version of FVTT comes out. All files have been fixed to pass eslint. This commit addresses outstanding bug/issues #36, #67, and #68 Co-authored-by: Mike Schoen <mkscho63@gmail.com>
mkscho63
added a commit
that referenced
this issue
Oct 12, 2022
* Refactor and update to weapon rolling system (#69) * adding nationalization strings and changes to support new weapon chat message * Changed sheet scripts to treat characterweapons and starshipweapons the same as regular items and call on actor.js rollGenericItem. Changed Actor.js to correctly use characterweapon items with roll.js performWeaponRoll(). Heavily overhauled roll.js. Created new helper functions to simplify repeated code, including generating strings from challenge dice, which is now down in multiple places. performWeaponRoll() now generates a nice weapon block for chat using the genericItemTemplate, and also generates the damage roll to append to it. I think it looks quite slick. The genericItemTemplate() now takes an itemId string and appends it to an html element as an attribute named data-item-id to enable functions from the Maestro module. i18n strings had to be changed for this new weapon roll display, this was done in a previous commmit. Damage for weapon rolls is computed directly at roll time from the weapon's base damage stat and the owner's security stat rather than scraping the number off the character sheet HTML. All rolls are now asynchronous, to match the upcoming changes in FoundryVTT. This will prevent depreciation warnings in the console, and breaking change headaches when the new version of FVTT comes out. All files have been fixed to pass eslint. This commit addresses outstanding bug/issues #36, #67, and #68 Co-authored-by: Mike Schoen <mkscho63@gmail.com> * V10 update (#77) * Dealing with all deprecation warnings, and abstracting the default image. * More v10 corrections. * Changed 'name' to 'id' in the system json * Removed unnecessary leading slash from defaultImage * Replace sidebar LCARS deco with hard gradient (#63) * Replace sidebar LCARS deco with hard gradient * Use overlayed gradients to fix background * Fixing issue with build and tracker swapped to hiding at the bottom * Fixing more v10 compatibility issues * pt_BR Translation for this module (#76) * Patch fr.json (#73) * Update fr.json Hello, it's just for a French translation or spelling * Update fr.json * v1.1.7 * fixing a couple minor issues before releasing 1.1.7 Co-authored-by: Ada <hiddenkrypt@gmail.com> Co-authored-by: IHaveThatPower <mcc@mcc3d.com> Co-authored-by: Sophia Pearson <codergal89@gmail.com> Co-authored-by: André S Nascimento <45982225+andre-s-nascimento@users.noreply.github.com> Co-authored-by: LaPatte <bearsurfeur@gmail.com>
mkscho63
added a commit
that referenced
this issue
Apr 19, 2023
* Merging in for 1.1.7 release (#78) * Refactor and update to weapon rolling system (#69) * adding nationalization strings and changes to support new weapon chat message * Changed sheet scripts to treat characterweapons and starshipweapons the same as regular items and call on actor.js rollGenericItem. Changed Actor.js to correctly use characterweapon items with roll.js performWeaponRoll(). Heavily overhauled roll.js. Created new helper functions to simplify repeated code, including generating strings from challenge dice, which is now down in multiple places. performWeaponRoll() now generates a nice weapon block for chat using the genericItemTemplate, and also generates the damage roll to append to it. I think it looks quite slick. The genericItemTemplate() now takes an itemId string and appends it to an html element as an attribute named data-item-id to enable functions from the Maestro module. i18n strings had to be changed for this new weapon roll display, this was done in a previous commmit. Damage for weapon rolls is computed directly at roll time from the weapon's base damage stat and the owner's security stat rather than scraping the number off the character sheet HTML. All rolls are now asynchronous, to match the upcoming changes in FoundryVTT. This will prevent depreciation warnings in the console, and breaking change headaches when the new version of FVTT comes out. All files have been fixed to pass eslint. This commit addresses outstanding bug/issues #36, #67, and #68 Co-authored-by: Mike Schoen <mkscho63@gmail.com> * V10 update (#77) * Dealing with all deprecation warnings, and abstracting the default image. * More v10 corrections. * Changed 'name' to 'id' in the system json * Removed unnecessary leading slash from defaultImage * Replace sidebar LCARS deco with hard gradient (#63) * Replace sidebar LCARS deco with hard gradient * Use overlayed gradients to fix background * Fixing issue with build and tracker swapped to hiding at the bottom * Fixing more v10 compatibility issues * pt_BR Translation for this module (#76) * Patch fr.json (#73) * Update fr.json Hello, it's just for a French translation or spelling * Update fr.json * v1.1.7 * fixing a couple minor issues before releasing 1.1.7 Co-authored-by: Ada <hiddenkrypt@gmail.com> Co-authored-by: IHaveThatPower <mcc@mcc3d.com> Co-authored-by: Sophia Pearson <codergal89@gmail.com> Co-authored-by: André S Nascimento <45982225+andre-s-nascimento@users.noreply.github.com> Co-authored-by: LaPatte <bearsurfeur@gmail.com> * v1.1.8 * Pushing 1.1.8 package * v1.1.9 * renaming package file * Update fr.json After many games it's more accurate translation :) * Update package.json Version update will be done by release automation --------- Co-authored-by: Mike Schoen <mkscho63@gmail.com> Co-authored-by: Ada <hiddenkrypt@gmail.com> Co-authored-by: IHaveThatPower <mcc@mcc3d.com> Co-authored-by: Sophia Pearson <codergal89@gmail.com> Co-authored-by: André S Nascimento <45982225+andre-s-nascimento@users.noreply.github.com>
mkscho63
added a commit
that referenced
this issue
Apr 19, 2023
* Merging in for 1.1.7 release (#78) * Refactor and update to weapon rolling system (#69) * adding nationalization strings and changes to support new weapon chat message * Changed sheet scripts to treat characterweapons and starshipweapons the same as regular items and call on actor.js rollGenericItem. Changed Actor.js to correctly use characterweapon items with roll.js performWeaponRoll(). Heavily overhauled roll.js. Created new helper functions to simplify repeated code, including generating strings from challenge dice, which is now down in multiple places. performWeaponRoll() now generates a nice weapon block for chat using the genericItemTemplate, and also generates the damage roll to append to it. I think it looks quite slick. The genericItemTemplate() now takes an itemId string and appends it to an html element as an attribute named data-item-id to enable functions from the Maestro module. i18n strings had to be changed for this new weapon roll display, this was done in a previous commmit. Damage for weapon rolls is computed directly at roll time from the weapon's base damage stat and the owner's security stat rather than scraping the number off the character sheet HTML. All rolls are now asynchronous, to match the upcoming changes in FoundryVTT. This will prevent depreciation warnings in the console, and breaking change headaches when the new version of FVTT comes out. All files have been fixed to pass eslint. This commit addresses outstanding bug/issues #36, #67, and #68 Co-authored-by: Mike Schoen <mkscho63@gmail.com> * V10 update (#77) * Dealing with all deprecation warnings, and abstracting the default image. * More v10 corrections. * Changed 'name' to 'id' in the system json * Removed unnecessary leading slash from defaultImage * Replace sidebar LCARS deco with hard gradient (#63) * Replace sidebar LCARS deco with hard gradient * Use overlayed gradients to fix background * Fixing issue with build and tracker swapped to hiding at the bottom * Fixing more v10 compatibility issues * pt_BR Translation for this module (#76) * Patch fr.json (#73) * Update fr.json Hello, it's just for a French translation or spelling * Update fr.json * v1.1.7 * fixing a couple minor issues before releasing 1.1.7 Co-authored-by: Ada <hiddenkrypt@gmail.com> Co-authored-by: IHaveThatPower <mcc@mcc3d.com> Co-authored-by: Sophia Pearson <codergal89@gmail.com> Co-authored-by: André S Nascimento <45982225+andre-s-nascimento@users.noreply.github.com> Co-authored-by: LaPatte <bearsurfeur@gmail.com> * v1.1.8 * Pushing 1.1.8 package * v1.1.9 * renaming package file * Add check for tag in actor name to allow attributes less than 7 Resolves #80 --------- Co-authored-by: Mike Schoen <mkscho63@gmail.com> Co-authored-by: Ada <hiddenkrypt@gmail.com> Co-authored-by: IHaveThatPower <mcc@mcc3d.com> Co-authored-by: Sophia Pearson <codergal89@gmail.com> Co-authored-by: André S Nascimento <45982225+andre-s-nascimento@users.noreply.github.com> Co-authored-by: LaPatte <bearsurfeur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Talents, values, focuses, armor and other items don't roll any dice when sent to the chat, but make a dice roll sound effect anyway.
To Reproduce
Open any character sheet. If they don't have a talent, value, focus, armor, or other item, add it, then click the chat button to send the item to chat. Make sure your sound is on and available.
Expected behavior
Such items should be silent, or generate a generic tone to indicate a chat message has come up, such as a star trek computer beep.
Desktop (please complete the following information):
Additional context
I will be including a fix to this in a upcoming merge request.
The text was updated successfully, but these errors were encountered: