Merge pull request #109 from mkslanc/wrong-service-type

Fix: wrong type
mkslanc · Mar 29, 2024 · f52b839 · f52b839
2 parents cad990e + 3bcc200
commit f52b839
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/packages/ace-linters/src/cdn-worker.ts b/packages/ace-linters/src/cdn-worker.ts
@@ -21,12 +21,12 @@ function createWorkerBlob(cdnUrl: string, services: ServiceStruct[]) {
 export function createWorker(services: {
     services: ServiceStruct[],
     serviceManagerCdn: string
-}, includeLinters?: { [name in SupportedServices]: boolean } | boolean): Worker
+}, includeLinters?: { [name in SupportedServices]: boolean | undefined } | boolean): Worker
 export function createWorker(cdnUrl: string, includeLinters?: { [name in SupportedServices]: boolean } | boolean): Worker
 export function createWorker(source: string | {
     services: ServiceStruct[],
     serviceManagerCdn: string
-}, includeLinters: { [name in SupportedServices]: boolean } | boolean = true) {
+}, includeLinters: { [name in SupportedServices]: boolean | undefined } | boolean = true) {
     if (typeof Worker == "undefined") return {
         postMessage: function () {
         },
@@ -50,7 +50,7 @@ export function createWorker(source: string | {
     return new Worker(blobURL);
 }
 
-function getServices(includeLinters: { [name in SupportedServices]: boolean } | boolean = true): ServiceStruct[] {
+function getServices(includeLinters: { [name in SupportedServices]: boolean | undefined } | boolean = true): ServiceStruct[] {
     const allServices = [
         {
             name: "json",

diff --git a/packages/ace-linters/src/language-provider.ts b/packages/ace-linters/src/language-provider.ts
@@ -73,13 +73,13 @@ export class LanguageProvider {
     static fromCdn(customServices: {
         services: ServiceStruct[],
         serviceManagerCdn: string,
-        includeDefaultLinters?: { [name in SupportedServices]: boolean } | true
+        includeDefaultLinters?: { [name in SupportedServices]: boolean | undefined } | true
     }, options?: ProviderOptions): LanguageProvider
     static fromCdn(cdnUrl: string, options?: ProviderOptions): LanguageProvider
     static fromCdn(source: string | {
         services: ServiceStruct[],
         serviceManagerCdn: string,
-        includeDefaultLinters?: { [name in SupportedServices]: boolean } | boolean
+        includeDefaultLinters?: { [name in SupportedServices]: boolean | undefined } | boolean
     }, options?: ProviderOptions) {
         let messageController: IMessageController;
         let worker: Worker;

diff --git a/packages/ace-linters/types/cdn-worker.d.ts b/packages/ace-linters/types/cdn-worker.d.ts
@@ -3,7 +3,7 @@ export declare function createWorker(services: {
     services: ServiceStruct[];
     serviceManagerCdn: string;
 }, includeLinters?: {
-    [name in SupportedServices]: boolean;
+    [name in SupportedServices]: boolean | undefined;
 } | boolean): Worker;
 export declare function createWorker(cdnUrl: string, includeLinters?: {
     [name in SupportedServices]: boolean;

diff --git a/packages/ace-linters/types/language-provider.d.ts b/packages/ace-linters/types/language-provider.d.ts
@@ -22,7 +22,7 @@ export declare class LanguageProvider {
         services: ServiceStruct[];
         serviceManagerCdn: string;
         includeDefaultLinters?: {
-            [name in SupportedServices]: boolean;
+            [name in SupportedServices]: boolean | undefined;
         } | true;
     }, options?: ProviderOptions): LanguageProvider;
     static fromCdn(cdnUrl: string, options?: ProviderOptions): LanguageProvider;