Kernel 6.4.10 breaks vmnet

[adilsond]

I build kernel 6.4.10 today and, when I tried to build the modules, I got the following errors:

CC [M] /tmp/vmware-build/vmnet-only/bridge.o
/tmp/vmware-build/vmnet-only/bridge.c: In function ‘VNetBridgeSendLargePacket’:
/tmp/vmware-build/vmnet-only/bridge.c:1416:11: error: implicit declaration of function ‘skb_gso_segment’; did you mean ‘tcp_gso_segment’? [-Werror=implicit-function-declaration]
1416 | segs = skb_gso_segment(skb, 0);
| ^~~~~~~~~~~~~~~
| tcp_gso_segment
/tmp/vmware-build/vmnet-only/bridge.c:1416:9: warning: assignment to ‘struct sk_buff *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
1416 | segs = skb_gso_segment(skb, 0);
| ^
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:252: /tmp/vmware-build/vmnet-only/bridge.o] Erro 1
make[1]: *** [Makefile:2032: /tmp/vmware-build/vmnet-only] Erro 2
make[1]: Saindo do diretório '/usr/src/linux-6.4.10'

make: *** [Makefile:117: vmnet.ko] Erro 2
cp: não foi possível obter estado de 'vmnet.ko': Arquivo ou diretório inexistente
Starting VMware services:
Virtual machine monitor done
Virtual machine communication interface done
VM communication interface socket family done
Virtual ethernet failed
VMware Authentication Daemon done

There is no issues with 6.4.9 and previous versions.

[adilsond]

I have found a solution for this problem. They moved skb_gso_segment function to a new file called net/gso.h

Here is a patch to fix this.

fix-6.4.10-breaks-vmnet-vmware-17.0.2.diff.gz

[mkubecek]

This should be already addressed by commit b75cd61 ("vmnet: add include for GSO related declarations"). I just didn't merge it into the workstation-* branches yet as there is another, more serious issue introduced in 6.5-rc1. But if this change was picked for a 6.4 stable backport, I'll do that now.

[lourdas]

Same here, running Gentoo with 6.4.10. Should we wait for the workstation-* branches?

[stefantalpalaru]

Commit b75cd61 fails to build for kernel 6.3.7, with:

/var/tmp/portage/app-emulation/vmware-modules-17.0.2-r2/work/vmware-host-modules-b75cd616cca0a4c9ff22124c4c91d218e64e6205/vmnet-only/bridge.c:49:10: fatal error: net/gso.h: No such file or directory
   49 | #include <net/gso.h>
      |          ^~~~~~~~~~~
compilation terminated.

[mkubecek]

Did you test that with current workstation-17.0.2 branch head (commit b75cd61)?

[stefantalpalaru]

Yes.

[mkubecek]

Should work now (commit 8b2d314), tested with 6.4.10 and 6.3.13.

[mkubecek]

Resolved in all active branches, closing.