Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Name Change for App... #21

Closed
onschedule opened this issue Feb 14, 2019 · 14 comments
Closed

Consider Name Change for App... #21

onschedule opened this issue Feb 14, 2019 · 14 comments
Projects
Milestone

Comments

@onschedule
Copy link
Contributor

Your App does so much more than Music Control. In my case, it also selects video source; allows receiver control via VPN, etc...

Maybe: Enhanced Onkyo Controller?

@mkulesh
Copy link
Owner

mkulesh commented Feb 14, 2019

Hi @onschedule, "Enhanced Onkyo Controller" is dangerous due to trademark violation. "Enhanced Controller for Onkyo" may be better. However, how I understand, the app works not only with Onkyo but also with Integra. "Enhanced Controller for Onkyo/Integra"? @mrlad do you have any ideas about new name?

@onschedule
Copy link
Contributor Author

onschedule commented Feb 14, 2019 via email

@mrlad
Copy link
Contributor

mrlad commented Feb 15, 2019

I have to think about it but my first thought is it's a pretty long name. Do think it would be wise to get both Onkyo and Integra in there though.

@mrlad
Copy link
Contributor

mrlad commented Feb 15, 2019

Speaking about VPN mentioned earlier, I tried to access a remote Integra via a VPN. Should I be able to manually put in the IP address of the receiver in the device tab? Subnet broadcast won't work over the VPN because I'm on a different subnet. IP address should be reachable though.

@mkulesh
Copy link
Owner

mkulesh commented Feb 15, 2019

Hi @mrlad, you are right, broadcast won't work over the VPN. If you however enters IP address of your receiver in the Connect dialog directly it shall work. You shall only ensure that this IP is reachable from your Android and 60128 port is not blocked on firewall (if any firewall(s) between your Android device and receiver exist(s)).

@mrlad
Copy link
Contributor

mrlad commented Feb 15, 2019

@mkulesh you're right, I got manual entry working by clicking the network icon by the address. I had assumed that once I entered the address it would try to connect. I'll open a UI suggestion issue for your consideration about this. But VPN is definitely working.

@mkulesh mkulesh added this to Analyzed in Release 0.8 Feb 19, 2019
@mkulesh mkulesh removed this from Analyzed in Release 0.8 Feb 26, 2019
@mkulesh mkulesh added this to Pending in Release 0.9 Feb 26, 2019
@gomanuke
Copy link
Collaborator

gomanuke commented Feb 27, 2019

Remote Controller for Onkyo will solve a problem from my modest opinion... Or more paranoid Remote Controller for Onkyo (tm)

@mkulesh
Copy link
Owner

mkulesh commented Feb 27, 2019

I think "Open Remote Controller for Onkyo" is better. I scheduled this issue for version 0.9.

@onschedule
Copy link
Contributor Author

onschedule commented Feb 27, 2019 via email

@mkulesh mkulesh removed this from Pending in Release 0.9 Feb 28, 2019
@mkulesh mkulesh added this to Implemented in Release 0.8 Feb 28, 2019
mkulesh added a commit that referenced this issue Feb 28, 2019
@mkulesh
Copy link
Owner

mkulesh commented Feb 28, 2019

Hi @onschedule, you are right about that the name should point to the enhanced functionality. I just slightly modified your initial variant and changed to name to "Enhanced Controller for Onkyo". This change affects:

  • App name presented in the application list in Android Settings
  • The name on Google Play (after I will publish the release 0.8)
  • The name on the image in the main navigation drawer
  • The name in the "About" dialog
  • The name on the main project page here: https://github.com/mkulesh/onpc, where I also added "Integra"

I started to test the release build 0.8 that I plan to publish at the beginning of the next week.
Could you please install it and test?
https://github.com/mkulesh/onpc/blob/autobuild/autobuild/onpc-v0.8-release.apk
Note: this a signed build, you may need to uninstall previous version.

@mkulesh mkulesh added this to the Implemented milestone Feb 28, 2019
@onschedule
Copy link
Contributor Author

onschedule commented Mar 1, 2019 via email

@mkulesh
Copy link
Owner

mkulesh commented Mar 4, 2019

Released in v0.8

@mkulesh mkulesh closed this as completed Mar 4, 2019
@onschedule
Copy link
Contributor Author

onschedule commented Aug 10, 2019 via email

@mkulesh
Copy link
Owner

mkulesh commented Aug 11, 2019

Hi @onschedule, could you please rise a new issue and attach screenshots where "Front USB" shall be changed to USB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.8
Implemented
Development

No branches or pull requests

4 participants