Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins are not loaded #62

Open
pbogut opened this issue Sep 8, 2016 · 3 comments
Open

Plugins are not loaded #62

pbogut opened this issue Sep 8, 2016 · 3 comments
Labels
Projects
Milestone

Comments

@pbogut
Copy link
Member

pbogut commented Sep 8, 2016

Master branch is not loading plugins.

It looks like the plugin loader is never called. Unless there was some breaking change? I can only tell that the Plugin class inside my plugin is never created.
It works fine in 0.2.1

PS.
plugin.json is now created in src directory, in 0.2.1 it was created in the root. Not sure if that's by design or missed in refactoring?

@mkusher
Copy link
Member

mkusher commented Sep 9, 2016

@pbogut plugins are not working with master, there were some BC. I'm thinking about how they should work now

@mkusher mkusher added the bug label Sep 9, 2016
@mkusher
Copy link
Member

mkusher commented Sep 9, 2016

I'm also not sure how it will work if we pack padawan as phar #49
@greg0ire what do you think about phar + plugins?

@mkusher mkusher added this to the 0.3 milestone Sep 9, 2016
@greg0ire
Copy link

greg0ire commented Sep 9, 2016

I think it's possible b/c the phpunit phar can load the code under test and additional libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants