This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Added Breadcrumb tag #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinlasek
requested review from
steffendsommer,
siemensikkema and
BrettRToomey
Closed
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
====================================
Coverage 0% 0%
====================================
Files 7 8 +1
Lines 215 263 +48
====================================
- Misses 215 263 +48
Continue to review full report at Codecov.
|
siemensikkema
approved these changes
Jun 20, 2018
| } | ||
|
|
||
| public final class BreadCrumbItemTag: TagRenderer { | ||
| public func render(tag: TagContext) throws -> EventLoopFuture<TemplateData> { |
# Conflicts: # Sources/Bootstrap/Bootstrap.swift
# Conflicts: # Sources/Bootstrap/Bootstrap.swift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we want to have child tags that make not much sense without their parent tags to be in the same file?
For example
#breadCrumbTag() {}is the parent and#breadCrumbItemTag() {}is the child and doesn't make that much sense to be used without its parent 馃槉