Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in notebook lecture 3 #6

Closed
nickvdw opened this issue Feb 23, 2020 · 1 comment
Closed

Issue in notebook lecture 3 #6

nickvdw opened this issue Feb 23, 2020 · 1 comment

Comments

@nickvdw
Copy link

nickvdw commented Feb 23, 2020

This is regarding 03 - Model Selection.ipynb.

The cell directly under

Model selection

  • Again, we can compare multiple models by looking at the ROC curves
  • We can calibrate the threshold depending on whether we need high recall or low FPR
  • We can select between algorithms (or hyperparameters) depending on the involved costs.

that plots the ROC curves for SVC and RF together with the thresholds (associated cell is In [39]: in the currently uploaded notebook) used

plt.plot(fpr_rf[close_default_rf], tpr[close_default_rf], '^', markersize=10,
         label="threshold 0.5 RF", fillstyle="none", c='k', mew=2)

for plotting the RF threshold, but this should be

plt.plot(fpr_rf[close_default_rf], tpr_rf[close_default_rf], '^', markersize=10,
         label="threshold 0.5 RF", fillstyle="none", c='k', mew=2)

instead, right?

@joaquinvanschoren
Copy link
Member

Yes indeed!
Thanks for noticing it. I fixed it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants