Added AMD GPU Support to Zeus #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amd_support rebase with master
|
Thanks for your work. Please resolve merge conflicts and make CI pass, and then request review. |
jaywonchung
reviewed
Apr 30, 2024
|
@jaywonchung fixed all merge conflicts and passing all tests, ready for review. |
jaywonchung
reviewed
Apr 30, 2024
jaywonchung
reviewed
May 1, 2024
jaywonchung
reviewed
May 1, 2024
|
@jaywonchung I went through and retested each method, and fixed any issues. It should be all correct now. |
jaywonchung
reviewed
May 2, 2024
| info = amdsmi.amdsmi_get_power_cap_info(self.handle) # Returns in W | ||
| amdsmi.amdsmi_set_power_cap( | ||
| self.handle, 0, cap=int(info["default_power_cap"] * 1e6) | ||
| ) # expects value in microwatts |
There was a problem hiding this comment.
Holy shit... 5.7 returns in microwatts but 6.0 returns in watts.... Is everything based on 5.7? Then let's keep it and later figure out how to make it work for 6.0...
There was a problem hiding this comment.
This is what I see, I was going off the source code for 6.0. So it should be correct for ROCM 6.0.
As for pytorch, it looks like it just got full support for ROCM 6.0 with the release of Pytorch 2.3 a week ago.
Should we stick to ROCM 6.0 then?
There was a problem hiding this comment.
Yep, if everything is consistent with 6.0, let's keep it that way!
jaywonchung
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AMD GPU support to Zeus. Involved adding method implementations to Zeus.device.gpu for the AMDGPU class.