Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to choose which projectors are plotted with dispersion #47

Merged
merged 4 commits into from May 29, 2020

Conversation

ml-evs
Copy link
Owner

@ml-evs ml-evs commented May 28, 2020

e.g. dispersion <seed> -p K:s,K:p,P:s.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #47 into master will decrease coverage by 0.05%.
The diff coverage is 60.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   74.22%   74.17%   -0.06%     
==========================================
  Files          89       89              
  Lines       11893    11928      +35     
==========================================
+ Hits         8828     8847      +19     
- Misses       3065     3081      +16     
Flag Coverage Δ
#unittests 74.17% <60.97%> (-0.06%) ⬇️
Impacted Files Coverage Δ
matador/plotting/spectral_plotting.py 78.23% <60.00%> (-1.44%) ⬇️
matador/cli/dispersion.py 94.00% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0469b9a...cbcbddc. Read the comment docs.

@ml-evs ml-evs merged commit 926232a into master May 29, 2020
@ml-evs ml-evs deleted the ml-evs/projector_updates branch May 29, 2020 11:27
@ml-evs ml-evs mentioned this pull request Jun 1, 2020
ml-evs added a commit that referenced this pull request Jun 1, 2020
- Optimised CIF reader considerably (#50)
- Updated PXRD calculator to allow for partial occupancy, monochromated beam angles and text export, and added ``pxrd_calculator`` script for convenience when handling CIF files (#50)
- Added ability to choose which projectors are plotted with dispersion (#47)
- Various minor fixes and updates:

    - Updates to docs for CLI and configuration.
    - Allow nan-values to be reset inside :class:`matador.crystal.Crystal`.
    - Fixed display ordering of fingerprint-filtered cursors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant