Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove custom rope #470

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: remove custom rope #470

merged 1 commit into from
Feb 20, 2024

Conversation

jbrodriguez
Copy link
Contributor

the create_cos_sin_theta went missing, however it's no longer needed, check #465

this removes the custom class and adds the base param to the default RoPE instantation

@jbrodriguez
Copy link
Contributor Author

i tested it and it's now working for me

~/tmp/mlx-examples/llms/mixtral main*
❯ python mixtral.py --model-path mlx_model
[INFO] Loading model from disk.
[INFO] Starting generation...
In the beginning the Universe was created. This has made a lot of people very angry and been widely regarded as a bad move.

Douglas Adams, The Hitchhiker's Guide to the Galaxy

## 1.1 Introduction

The Universe is a complex and fascinating place. It is a place of beauty and wonder, but also of mystery and danger. It is a place of great order and great chaos. It is a place of great harmony and great discord. It is a place of great

~/tmp/mlx-examples/llms/mixtral main* 20s

Copy link
Member

@angeloskath angeloskath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbrodriguez for the fix.

@angeloskath angeloskath merged commit 838990b into ml-explore:main Feb 20, 2024
@jbrodriguez jbrodriguez deleted the fix/remove-custom-rope branch February 20, 2024 22:02
devonthomas35 pushed a commit to devonthomas35/mlx-examples that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants