Append visionOS support #56
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
approved these changes
Mar 28, 2024
|
CI failed the swift-format check. Can you run: Thanks! |
|
@davidkoski I just applied a typo fix for CI. I think it's OK now. |
|
@awni can same thing be done for iPadOS? Some of iPads have M chips so that make MLX even faster on them |
|
I think it already works for iPad (Pretty sure @davidkoski has tested this). |
|
Yes, I have tested on iPad Pro M2 and it works great. That said it also works great on non Apple Silicon (well, the M series) like an iPhone 12 Pro Max -- it runs the LLMEval example without a problem, though not as fast as the more powerful models. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just add few lines of code to allow compilation on visionOS