Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set item bug fix #879

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Set item bug fix #879

merged 2 commits into from
Mar 22, 2024

Conversation

jagrit06
Copy link
Member

Proposed changes

Fixes bug in #873 and adds additional tests for similar cases

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@jagrit06 jagrit06 requested a review from awni March 22, 2024 18:42
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thanks for the quick fix!!

@jagrit06 jagrit06 merged commit 8e5a5a1 into main Mar 22, 2024
3 checks passed
@jagrit06 jagrit06 deleted the set-item-bug-fix branch March 22, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants