Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The bodypart_onehot feature should set "head/other" to True for "head", "other" and "head/other" #275

Closed
probberechts opened this issue Apr 30, 2022 · 0 comments
Closed

The bodypart_onehot feature should set "head/other" to True for "head", "other" and "head/other" #275

probberechts opened this issue Apr 30, 2022 · 0 comments

Comments

@probberechts
Copy link
Member

No description provided.

probberechts added a commit that referenced this issue Jul 9, 2022
@probberechts
Fix bodypart_onehot feature
e566835 
This feature generator now sets "bodypart_head/other" to True for "head", "other" and "head/other". This means that for data providers that distinguish between "head" and "other" (i.e., Opta, StatsPerform and StatsBomb), two of the output columns will be True. The behaviour does not change for data providers (i.e., Wyscout) that do not distinguish between the "head" and "other" body parts.

Fixes #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@probberechts