Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RyeViewController.swift #16

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Update RyeViewController.swift #16

merged 1 commit into from
Sep 30, 2019

Conversation

bellebethcooper
Copy link
Contributor

Removed a print statement that's cluttering up my console during usage. Guessing maybe this is leftover from debugging, but apologies if it needs to be there!

Removed a print statement that's cluttering up my console during usage.
@pbodsk
Copy link
Contributor

pbodsk commented Sep 30, 2019

Hi @bellebethcooper

Thank you so much for your contribution, glad to see that you are using Rye 😄

You are right, that was a leftover from a debugging session and should be removed, nice catch.

I can merge your PR now, unless you are participating in this years Hacktober, in which case I can wait till tomorrow (October 1st) and it can count as an "entry" in the Hacktober event.. Let me know what you're thinking.

@bellebethcooper
Copy link
Contributor Author

No problem! I do this same thing in my own projects a lot, so glad to help catch this one 😊 Happy to have the PR merged whenever you're ready, but thanks for checking. And thanks again for Rye!

@pbodsk pbodsk merged commit bda1c4f into ml-opensource:master Sep 30, 2019
@pbodsk
Copy link
Contributor

pbodsk commented Sep 30, 2019

@bellebethcooper there we go, version https://github.com/nodes-ios/Rye/releases/tag/1.1.8 is ready for you to try out. I took the liberty of removing some more print statements.

I'll be sure to pass your "thanks" forward to the rest of the gang 👍

@bellebethcooper
Copy link
Contributor Author

@pbodsk Brilliant, thanks very much!

@bellebethcooper bellebethcooper deleted the patch-1 branch October 5, 2019 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants