Bugfix backproject_voxel #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you don't do this ,it crashes in line 309 (if), complaining that the truth of a series is ambiguous.
.max() seems to return numpy integer. It crashes when you try raise by a negative integer, just try: `np.int64(1) ** -1`
|
Thanks for pointing this out — I'm going to close this as we already caught these bugs (and some others) last week and will be including these fixes in our
Nevertheless, please let us know if you find anything else! |
|
Also: if you are interested in the source code for the upcoming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when we try to run step 4, we encounter several crashes. This fixes them I hope :-) We are currently running a test.
Best,
Thorsten