Changed subprocess.run command in launch_ui function #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JopaXd
requested review from
JanKalkan,
LukasMasuch and
raethlein
as code owners
|
@JopaXd Thanks for the fix :) Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Description:
I made a change in the subprocess.run command in the launch_ui function. Sys.executable is now in quotes so that it can work with paths that contain spaces. I ran "opyrator launch-ui main:hello_world", main being the file and hello_world being the function on my Windows 10 machine and I get the error "C:/Program is not recognized as an internal or external command, operable program or batch file" since my python installation is located under C:/Program Files/Python39. This PR fixes that issue.
Checklist: