Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle include #35

Merged
merged 8 commits into from Feb 4, 2019
Merged

handle include #35

merged 8 commits into from Feb 4, 2019

Conversation

BeckySharp
Copy link
Contributor

now handling the include env in the same way as import

softened exceptions to printed warnings bc it was crashing (they weren't being caught) at runtime

@BeckySharp
Copy link
Contributor Author

BeckySharp commented Feb 3, 2019

there aren't a ton of eqns to test this one, paper 1812.08535 has some (not in the little dev set you have, i can send if you want).
With this, the AABBs seem to be a little off, and they are not affected by either rescaling or attempts to increase the range of image resizings.
regardless of this, I think this is useful if for no other reason than equations, as include seems to be used to import files of custom macros

@marcovzla
Copy link
Contributor

Can we take a look at the AABBs on monday?
Otherwise, LGTM.

@BeckySharp
Copy link
Contributor Author

wouldn't it be funny if I responded with 👎 instead? I bet the thumbs up and down have VERY diff frequencies in github PR threads... :)

@marcovzla marcovzla merged commit 0ce24a6 into master Feb 4, 2019
@marcovzla marcovzla deleted the imports branch February 4, 2019 21:37
@marcovzla
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants