Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Utilities #27

Closed
shiffman opened this issue Nov 21, 2017 · 4 comments
Closed

Image Utilities #27

shiffman opened this issue Nov 21, 2017 · 4 comments

Comments

@shiffman
Copy link
Member

shiffman commented Nov 21, 2017

Related to #26 #24 #21 #15, there are going to be many examples working with images. There are some awkward things now that perhaps we can handle internally and/or with an "image utility" class for the library that handles the images <--> NDArray stuff.

  1. Should all functions that receive an image should work with DOM elements (<img>, <video>, <canvas>, p5.Image objects, and pixels arrays?
  2. I've noticed our examples only work with certain square dimensions 127x127, 227x227, etc. There are likely performance considerations but ideally the library could handle internally any image resizing necessary.

What else?

@cvalenzuela
Copy link
Member

Adding specific utilities for the <video> tag could be nice too. Like managing frame rates.

I can work on this.

@cvalenzuela cvalenzuela self-assigned this Jan 31, 2018
@BarakChamo
Copy link

I can start working on a wrapper around dealing with image data sources (i.e. urls, <img/>, <canvas/>, Image() and p5.Image).

If one of the goals of this library is to be easily compatible but not tied to to p5.js then it's probably best to abstract all of these modules from the model code.

@cvalenzuela cvalenzuela removed their assignment Feb 1, 2018
@BarakChamo
Copy link

BarakChamo commented Feb 1, 2018

Implementation will follow the fromPixels method on Array3D
https://deeplearnjs.org/docs/api/classes/array3d.html#frompixels

@cvalenzuela
Copy link
Member

This seems to be solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants