Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples and p5 #70

Closed
shiffman opened this issue Feb 26, 2018 · 4 comments
Closed

examples and p5 #70

shiffman opened this issue Feb 26, 2018 · 4 comments
Assignees
Labels

Comments

@shiffman
Copy link
Member

This is related to #27 as well as pull requests #69 and #66. I'm reposting a comment I made on @dariusk's amazing recommendations document! Perhaps we can discuss at our meeting on Thursday.


Regarding the p5 examples, I would love to have a discussion about how to manage this. One of the reasons things skewed towards p5 is that I hope to integrate it into my beginner programming classes with p5, but this is probably not helpful for the larger web audience and adds unnecessary extra stuff where simple vanilla JS makes the most sense. I see a few options here:

  1. Maintain a separate repo with a p5 + ml5 examples.
  2. Maintain two sets of examples here with ml5 itself.
  3. Use p5 only where p5 shines (i.e. if we're making heavy use of canvas drawing, webcam capture, loading a CSV, etc.) but otherwise stick with vanilla JS.

Thoughts?

@cvalenzuela
Copy link
Member

I like how p5 allows simplifying things. However, this might get in the way of showing how the library can be used in combination with other frameworks.

I think a combination of 1 and 3 might work. Having a separate repo with a collection of examples of ML5 + p5.js might also allow people to contribute more to the project.

Let's discuss it on Thursday!

@dariusk
Copy link
Contributor

dariusk commented Feb 27, 2018

I agree, 1 & 3 seem like a good combination. This is partly why I've been submitting p5-less PRs on like, the non-canvas examples.

@shiffman
Copy link
Member Author

Thanks I'll leave this open as a reminder, we can discuss a bit more on Thursday too. I would be happy to take the lead on maintaining the "p5+ml5" examples repo should we go that route.

@cvalenzuela
Copy link
Member

The new examples structure addresses this issue. We now have a folder with p5js examples only and another folder with 'vanilla' javascript examples.
Closing this for now, but we can re-open this thread if necessary in the examples repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants