Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when all labels are the same #1259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ximenasandoval
Copy link

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Describe your Pull Request πŸ“

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?

If we train a NN with data with just one label throughout the dataset, the training will fail. This
changes introduce an error message to prompt the user of the error and prevent from training.

Fix #1179

A great PR 🌟🌟

β†’ Step 2: Share a Relevant Example πŸ¦„

The error can be reproduced here (thanks to @seoj for providing an example in issue #990)
https://jsfiddle.net/f4zk71s8/

The best PR 🌟🌟🌟

β†’ Step 3: Screenshots or Relevant Documentation πŸ–Ό

image

… in the dataset

If we train a NN with data with just one label throughout the dataset, the training will fail. This
changes introduces an error message to prompt the user of the error

fix ml5js#1179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add a verbose error message when Neural Network's addData() is called without correct arguments
1 participant