Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devops] disable webpack host check #634

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Conversation

joeyklee
Copy link
Contributor

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Which branch are you submitting to? 🌲

Development (for new features or updates), Release (for bug fixes), or ___________?

  • development

β†’ Step 2: Describe your Pull Request πŸ“

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?

  • fixing a bug
  • adding an update

Currently fixes an issue with webpack dev server that throws a warning in the browser that the host is invalid by setting disableHostCheck: true,

Screen Shot 2019-10-16 at 10 25 16

@joeyklee joeyklee merged commit ba3bf2e into development Oct 16, 2019
@joeyklee joeyklee deleted the webpack-host-check branch October 16, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant