Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style "send invites" member list #52

Closed
JonathanReeve opened this issue Jul 3, 2014 · 3 comments
Closed

style "send invites" member list #52

JonathanReeve opened this issue Jul 3, 2014 · 3 comments
Labels
bug

Comments

@JonathanReeve
Copy link
Contributor

No description provided.

JonathanReeve added a commit that referenced this issue Jul 3, 2014
@JonathanReeve
wrap item elements in .item, fixes #52
7358766
@JonathanReeve
Copy link
Contributor Author

This wrap apparently doesn't apply when the "send invites" list is empty, and a user selects contacts to invite. The AJAX request here is apparently loading some HTML from somewhere else that doesn't contain this wrap. Reopening.

screen shot 2014-07-16 at 4 40 03 pm

@JonathanReeve JonathanReeve reopened this Jul 16, 2014
@JonathanReeve
Copy link
Contributor Author

It looks like this is because bp-themes/bp-default/_inc/ajax.php:55 (bp_dtheme_ajax_invite_user()) has the HTML hard-coded.

JonathanReeve added a commit that referenced this issue Jul 17, 2014
@JonathanReeve
Revert "wrap item elements in .item, fixes #52"
e5ccc72 
This reverts commit 7358766.
JonathanReeve added a commit that referenced this issue Jul 17, 2014
@JonathanReeve
style send invite form the long way, fixes #52 finally
adcc5e7
@JonathanReeve
Copy link
Contributor Author

By the way, this turned into a very animated discussion at Buddypress here: https://buddypress.trac.wordpress.org/ticket/5759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonathanReeve