WIP: blockfrost module and test #81

avnik · 2024-05-27T17:59:16Z

No description provided.

aciceri

I prepared a branch with minimal changes to make CI happy. Feel free to re-implement them here.

Also in the branch I'm also starting an ssh server so that you can connect with ssh root@localhost -p 2000 after having started the test interactively with nix run .#vmTests-blockfrost -- --interactive.
I don't if you already knew this "trick" but I believe it can help a lot.

Moreover if possible let's test something more significative besides /health, perhaps we can check /blocks/latest to see if the slot number is greater than a certain amount? Something similar to what we did for cardano-db-sync I mean.

aciceri · 2024-05-31T14:22:42Z

flake.nix

+    blockfrost = {
+      url = "github:blockfrost/blockfrost-backend-ryo?ref=v2.0.2";
+    };


We support multiple versions for the same packages now. Even if we'll have only one blockfrost for now I would already start preparing multiple blockfrost versions support for instance by renaming this input to something like blockrost-2.0.2. Feel free to address this in another PR so that we can merge this ASAP.

Take a look at what has been done for cardano-node, ogmios and kupo. Also you should export the blockfrost derivation between this flake's packages.

At the moment this done only for node, -- kupo, dbsync, ogmios remain unversioned (and I feel this versioning follow to bloating code, and should be used only when neccesary). So should I rename it?

Ok let's ignore this until we support multiple versions.

aciceri · 2024-05-31T14:26:09Z

tests/blockfrost.nix

+        machine.wait_until_succeeds("""[[ $(echo "$(cardano-cli query tip --testnet-magic ${magic} | jq '.syncProgress' --raw-output) > 0.001" | bc) == "1" ]]""")
+        machine.wait_for_unit("blockfrost-backend-ryo")
+        time.sleep(10)
+        machine.succeed("curl http://localhost:3000/health")


I believe it's /api/v0/health

Nope, /api/v0 is only on public instances, local ones have straight /health

aciceri · 2024-05-31T14:27:11Z

tests/blockfrost.nix

+        machine.wait_for_unit("cardano-node-socket")
+        machine.wait_until_succeeds("""[[ $(echo "$(cardano-cli query tip --testnet-magic ${magic} | jq '.syncProgress' --raw-output) > 0.001" | bc) == "1" ]]""")
+        machine.wait_for_unit("blockfrost-backend-ryo")
+        time.sleep(10)


The reason why the test is failing is because this is not enough in CI. Anyway I would avoid using timeouts like this and suggest machine.wait_until_succeeds().

aciceri · 2024-05-31T14:27:44Z

tests/blockfrost.nix

+        time.sleep(10)
+        machine.succeed("curl http://localhost:3000/health")
+        machine.succeed("curl --silent --fail http://localhost:3000/health")
+        print(machine.succeed("systemd-analyze security blockfrost"))


For some reason this is also returning non-zero, I haven't investigated it.

Different module name, it should be "blockfrost-ryo". Already fixed this

aciceri

@brainrake could you also please take a look? Especially for what concerns the internal coherence with other modules and if the options interface really makes sense in all cases (what if one runs postgres on a different machine? These kind of scenarios I mean...). I was wondering if it should also have an assertion but I'm not sure what it should assert.

PS: @avnik remember to check how docs look like

aciceri · 2024-06-25T13:28:36Z

flake.nix

+    blockfrost = {
+      url = "github:blockfrost/blockfrost-backend-ryo?ref=v2.0.2";
+    };


Ok let's ignore this until we support multiple versions.

aciceri · 2024-06-25T13:30:06Z

modules/blockfrost.nix

+        mkEnableOption ''
+        '';


Shouldn't we put something here?

Check here. I t would be nice also having an example.

aciceri · 2024-06-25T13:32:11Z

modules/blockfrost.nix

+        enable = true;
+        settings = {
+          inherit (config.cardano) network;
+          server.debug = true;


This is related to logs, right? Do we want it by default? Don't have a strong opinion honestly...

Yes, debug probably could be removed. Was need to figure out that we had db connection issues

aciceri · 2024-06-25T13:40:14Z

tests/blockfrost.nix

+  perSystem.vmTests.tests.blockfrost = {
+    impure = true;
+    module = {
+      nodes .machine = {pkgs, ...}: {


Suggested change

nodes .machine = {pkgs, ...}: {

nodes.machine = {pkgs, ...}: {

aciceri · 2024-06-25T13:40:38Z

modules/blockfrost.nix

+        ProtectKernelModules = true;
+        SystemCallArchitectures = "native";
+        # FIXME: Turn MemoryDenyWriteExecute prevent service from work
+        #          MemoryDenyWriteExecute = true;


Suggested change

# MemoryDenyWriteExecute = true;

# MemoryDenyWriteExecute = true;

aciceri · 2024-06-25T13:40:48Z

modules/blockfrost.nix

+        ProtectKernelTunables = true;
+        RestrictRealtime = true;
+        # FIXME: Turn SystemCallFilter prevent service from work
+        #          SystemCallFilter = ["@system-service" "~@privileged"];


Suggested change

# SystemCallFilter = ["@system-service" "~@privileged"];

# SystemCallFilter = ["@system-service" "~@privileged"];

modules/blockfrost.nix

Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>

Co-authored-by: Andrea Ciceri <andrea.ciceri@autistici.org> Co-authored-by: Alexander V. Nikolaev <avn@avnik.info> Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>

Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>

Improved behaviour in case when db-sync and/or postgress not enabled locally Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>

It was causing issues with package options having as default values packages not in `pkgs`

avnik marked this pull request as draft May 27, 2024 17:59

avnik force-pushed the avnik/blockfrost branch from ce5ddc2 to bf57882 Compare May 28, 2024 00:06

avnik requested a review from aciceri May 28, 2024 15:23

aciceri reviewed May 31, 2024

View reviewed changes

avnik force-pushed the avnik/blockfrost branch from 69cae89 to 4c3346b Compare June 18, 2024 14:40

aciceri reviewed Jun 25, 2024

View reviewed changes

avnik force-pushed the avnik/blockfrost branch from f530b91 to e35fc0c Compare June 25, 2024 15:18

brainrake requested changes Jun 29, 2024

View reviewed changes

avnik and others added 5 commits July 5, 2024 14:06

blockfrost module and test

d83f84a

Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>

Make blockfrost module pass initial test

4c4e8b4

Co-authored-by: Andrea Ciceri <andrea.ciceri@autistici.org> Co-authored-by: Alexander V. Nikolaev <avn@avnik.info> Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>

Post-review fixups

c17bf97

Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>

blockfrost: Post-review improvements

a5c44a9

Improved behaviour in case when db-sync and/or postgress not enabled locally Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>

Add doc links for blockfrost

2d0f451

avnik force-pushed the avnik/blockfrost branch from cc87de8 to 2d0f451 Compare July 5, 2024 13:26

aciceri added 4 commits July 5, 2024 17:49

Fix typo

6535445

Fix typo in comment

eb69580

Remove unneded hack

fd189e7

It was causing issues with package options having as default values packages not in `pkgs`

Not needed anymore

75674b6

nrutledge mentioned this pull request Jul 8, 2024

Blockfrost #73

Closed

Improve comment about SystemCallFilter

5d17438

aciceri marked this pull request as ready for review July 15, 2024 10:32

aciceri merged commit 8a4df85 into main Jul 15, 2024
2 checks passed

aciceri deleted the avnik/blockfrost branch July 15, 2024 10:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: blockfrost module and test #81

WIP: blockfrost module and test #81

avnik commented May 27, 2024

aciceri left a comment •

edited

Loading

aciceri May 31, 2024

aciceri May 31, 2024

avnik Jun 18, 2024

aciceri Jun 25, 2024

aciceri May 31, 2024

avnik Jun 18, 2024

aciceri May 31, 2024

aciceri May 31, 2024

avnik Jun 18, 2024

aciceri left a comment •

edited

Loading

aciceri Jun 25, 2024

aciceri Jun 25, 2024

aciceri Jun 25, 2024

aciceri Jun 25, 2024

avnik Jun 25, 2024

aciceri Jun 25, 2024

aciceri Jun 25, 2024

aciceri Jun 25, 2024

	nodes .machine = {pkgs, ...}: {
	nodes.machine = {pkgs, ...}: {

	# MemoryDenyWriteExecute = true;
	# MemoryDenyWriteExecute = true;

	# SystemCallFilter = ["@system-service" "~@privileged"];
	# SystemCallFilter = ["@system-service" "~@privileged"];

WIP: blockfrost module and test #81

WIP: blockfrost module and test #81

Conversation

avnik commented May 27, 2024

aciceri left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aciceri left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aciceri left a comment •

edited

Loading

aciceri left a comment •

edited

Loading